[
https://issues.apache.org/jira/browse/HADOOP-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039775#comment-14039775
]
Hudson commented on HADOOP-9559:
--------------------------------
SUCCESS: Integrated in Hadoop-Yarn-trunk #590 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/590/])
HADOOP-9559. When metrics system is restarted MBean names get incorrectly
flagged as dupes. Contributed by Mostafa Elhemali and Mike Liddell. (cnauroth:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1604225)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/DefaultMetricsSystem.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/util/MBeans.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
> When metrics system is restarted MBean names get incorrectly flagged as dupes
> -----------------------------------------------------------------------------
>
> Key: HADOOP-9559
> URL: https://issues.apache.org/jira/browse/HADOOP-9559
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Affects Versions: 3.0.0, 2.4.0
> Reporter: Mostafa Elhemali
> Assignee: Mike Liddell
> Fix For: 3.0.0, 2.5.0
>
> Attachments: HADOOP-9559.2.patch, HADOOP-9559.patch
>
>
> In the Metrics2 system, every source gets registered as an MBean name, which
> gets put into a unique name pool in the singleton DefaultMetricsSystem
> object. The problem is that when the metrics system is shutdown (which
> unregisters the MBeans) this unique name pool is left as is, so if the
> metrics system is started again every attempt to register the same MBean
> names fails (exception is eaten and a warning is logged).
> I think the fix here is to remove the name from the unique name pool if an
> MBean is unregistered, since it's OK at this point to add it again.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
