[ 
https://issues.apache.org/jira/browse/HADOOP-10735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liu updated HADOOP-10735:
----------------------------

    Attachment: HADOOP-10735.005.patch

Thanks [~umamaheswararao] for the comments.

{quote}
Can't we use getClasses from config instead? atleast this peice of code should 
be qualified as util method.
{quote}
OK. I move it to {{Configuration}} and accept generic type as following:
{code}
public <U> List<Class<? extends U>> getClasses(String name, 
      Class<U> xface, List<Class<? extends U>> defaultValue) {
…
}
{code}

{quote}
Why cann't it be HadoopIllegalArgumentException instead of IAException?
{quote}
{{HadoopIllegalArgumentException}} only accepts string, I’m not going to add an 
overload constructor for it.


> Fall back AesCtrCryptoCodec implementation from OpenSSL to JCE if non native 
> support.
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10735
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10735
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>             Fix For: fs-encryption (HADOOP-10150 and HDFS-6134)
>
>         Attachments: HADOOP-10735.001.patch, HADOOP-10735.002.patch, 
> HADOOP-10735.003.patch, HADOOP-10735.004.patch, HADOOP-10735.005.patch
>
>
> If there is no native support or OpenSSL version is too low not supporting 
> AES-CTR, but {{OpensslAesCtrCryptoCodec}} is configured, we need to fall back 
> it to JCE implementation.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to