[
https://issues.apache.org/jira/browse/HADOOP-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061031#comment-14061031
]
Haohui Mai commented on HADOOP-10468:
-------------------------------------
bq. My preference would be to just fix the test if that's sufficient since it
retains the semantic behavior. However if we really need to remove the
lowercase call as in the original patch then I think we should also change the
places where we register metrics to register them with lowercase strings. That
would retain compatibility with existing metrics properties configuration files.
Fixing only the test looks okay to me. The current semantic of the metric
configuration, however, seems pretty confusing. For example, the original test
case in {{testMultiThreadedPublish()}} actually looks quite legit. I did a
quick search and it does not seem that the behavior is documented, I suspect
that many configurations are silently ignored as there are no messages on
unrecognized values. Therefore, I think it might be worthwhile to fix the
semantic in trunk. Thoughts?
> TestMetricsSystemImpl.testMultiThreadedPublish fails intermediately
> -------------------------------------------------------------------
>
> Key: HADOOP-10468
> URL: https://issues.apache.org/jira/browse/HADOOP-10468
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Priority: Blocker
> Attachments: HADOOP-10468.000.patch, HADOOP-10468.001.patch,
> HADOOP-10468.2.patch
>
>
> {{TestMetricsSystemImpl.testMultiThreadedPublish}} can fail intermediately
> due to the insufficient size of the sink queue:
> {code}
> 2014-04-06 21:34:55,269 WARN impl.MetricsSinkAdapter
> (MetricsSinkAdapter.java:putMetricsImmediate(107)) - Collector has a full
> queue and can't consume the given metrics.
> 2014-04-06 21:34:55,270 WARN impl.MetricsSinkAdapter
> (MetricsSinkAdapter.java:putMetricsImmediate(107)) - Collector has a full
> queue and can't consume the given metrics.
> 2014-04-06 21:34:55,271 WARN impl.MetricsSinkAdapter
> (MetricsSinkAdapter.java:putMetricsImmediate(107)) - Collector has a full
> queue and can't consume the given metrics.
> {code}
> The unit test should increase the default queue size to avoid intermediate
> failure.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
