[
https://issues.apache.org/jira/browse/HADOOP-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061068#comment-14061068
]
Jason Lowe commented on HADOOP-10468:
-------------------------------------
Thanks for commenting, Haohui. +1 to just fixing the test case in branch-2 for
now. Given it's been this way for 4 years I'm hesitant to change this, even in
trunk, because other systems outside of Hadoop core could be using it and
changing the case could break them in a similar way. If we do change the
semantics in trunk then I strongly suggest we go ahead and lowercase the
registered names of existing entities, e.g.:
{{DefaultMetricsSystem.initialize("namenode");}} instead of
{{DefaultMetricsSystem.initialize("NameNode");}} to minimize the breakage to
existing metrics2 config files.
So I propose we commit this to trunk, branch-2, and branch-2.5 and track the
proposed change to trunk in a separate JIRA where we can discuss whether the
backwards compatibility breakage is worth it. Objections?
> TestMetricsSystemImpl.testMultiThreadedPublish fails intermediately
> -------------------------------------------------------------------
>
> Key: HADOOP-10468
> URL: https://issues.apache.org/jira/browse/HADOOP-10468
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Priority: Blocker
> Attachments: HADOOP-10468.000.patch, HADOOP-10468.001.patch,
> HADOOP-10468.2.patch
>
>
> {{TestMetricsSystemImpl.testMultiThreadedPublish}} can fail intermediately
> due to the insufficient size of the sink queue:
> {code}
> 2014-04-06 21:34:55,269 WARN impl.MetricsSinkAdapter
> (MetricsSinkAdapter.java:putMetricsImmediate(107)) - Collector has a full
> queue and can't consume the given metrics.
> 2014-04-06 21:34:55,270 WARN impl.MetricsSinkAdapter
> (MetricsSinkAdapter.java:putMetricsImmediate(107)) - Collector has a full
> queue and can't consume the given metrics.
> 2014-04-06 21:34:55,271 WARN impl.MetricsSinkAdapter
> (MetricsSinkAdapter.java:putMetricsImmediate(107)) - Collector has a full
> queue and can't consume the given metrics.
> {code}
> The unit test should increase the default queue size to avoid intermediate
> failure.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
