[ 
https://issues.apache.org/jira/browse/HADOOP-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138614#comment-14138614
 ] 

Hadoop QA commented on HADOOP-10970:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12669650/hadoop-10970.005.patch
  against trunk revision ee21b13.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in 
hadoop-common-project/hadoop-kms 

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/4755//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/4755//console

This message is automatically generated.

> Cleanup KMS configuration keys
> ------------------------------
>
>                 Key: HADOOP-10970
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10970
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.5.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hadoop-10970.001.patch, hadoop-10970.002.patch, 
> hadoop-10970.003.patch, hadoop-10970.004.patch, hadoop-10970.005.patch
>
>
> It'd be nice to add descriptions to the config keys in kms-site.xml.
> Also, it'd be good to rename key.provider.path to key.provider.uri for 
> clarity, or just drop ".path".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to