[ https://issues.apache.org/jira/browse/HADOOP-11017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145609#comment-14145609 ]
Karthik Kambatla commented on HADOOP-11017: ------------------------------------------- Actually, I see why the get/set/incr methods are added, but it looks like there are a couple of inconsistencies. ZKDTSM should either maintain its own counter or re-use delegationTokenSeqNumber. # If its using its own counter, methods in ADTSM should be synchronized. # If its re-using delegationTokenSeqNumber from ADTSM, (1) we don't need a getter, (2) incr should probably call set so the value is updated, (3) set should lock on write. > KMS delegation token secret manager should be able to use zookeeper as store > ---------------------------------------------------------------------------- > > Key: HADOOP-11017 > URL: https://issues.apache.org/jira/browse/HADOOP-11017 > Project: Hadoop Common > Issue Type: Improvement > Components: security > Affects Versions: 2.6.0 > Reporter: Alejandro Abdelnur > Assignee: Arun Suresh > Fix For: 2.6.0 > > Attachments: HADOOP-11017.1.patch, HADOOP-11017.10.patch, > HADOOP-11017.11.patch, HADOOP-11017.12.patch, HADOOP-11017.2.patch, > HADOOP-11017.3.patch, HADOOP-11017.4.patch, HADOOP-11017.5.patch, > HADOOP-11017.6.patch, HADOOP-11017.7.patch, HADOOP-11017.8.patch, > HADOOP-11017.9.patch, HADOOP-11017.WIP.patch > > > This will allow supporting multiple KMS instances behind a load balancer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)