[
https://issues.apache.org/jira/browse/HADOOP-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232506#comment-14232506
]
Arun Suresh commented on HADOOP-10788:
--------------------------------------
Thanks for the patch [~aw],
One minor thing though.. in *kms-config.sh* :
{noformat}
export KMS_SSL_KEYSTORE_PASS="${KMS_SSL_KEYSTORE_PASS:-password}"
{noformat}
KMS_SSL_KEYSTORE_PASS must be set to *password* ONLY if it is explicitly set to
"", else if will be set to *password* even in the non-ssl case and will always
enter the if statement in *kms.sh* :
{noformat}
+ if [[ -n "${KMS_SSL_KEYSTORE_PASS}" ]] || [[ -n "${KMS_SSL_TRUSTSTORE_PASS}"
]]; then
..
{noformat}
> Rewrite kms to use new shell framework
> --------------------------------------
>
> Key: HADOOP-10788
> URL: https://issues.apache.org/jira/browse/HADOOP-10788
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Labels: scripts
> Attachments: HADOOP-10788-01.patch, HADOOP-10788.patch
>
>
> kms was not rewritten to use the new shell framework. It should be reworked
> to take advantage of it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
