[ 
https://issues.apache.org/jira/browse/HADOOP-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-11464:
-----------------------------------
    Attachment: HADOOP-11464.003.patch

Thanks for the review, Allen.  Thanks also for the pointer on shellcheck.  I'm 
using it now.

I'm attaching v003.  Here is a summary of the changes:
* Nice catch on {{JAVA_LIBRARY_PATH}}.  I hadn't covered that in my testing.  
This is getting translated now.
* The shellcheck errors are cleaned up.  For the warning about single quotes, I 
chose to suppress it.  We really want single quotes here, because the 
{{cygpath}} command translates the classpath to use the Windows-style 
separator, which is ;.  Since this is part of a bash {{eval}}, the semicolons 
would get misinterpreted as multiple bash commands.  Wrapping it in single 
quotes handles it correctly.
* I'd prefer to punt on the Tomcat stuff for now, mostly because I don't have 
bandwidth to test it fully right now.
* I updated the comment in {{hadoop_os_tricks}}.  Is this what you had in mind?
* I added translation for the special cases in bin/yarn.
* Equivalent changes are applied to branch-2 also.

> Reinstate support for launching Hadoop processes on Windows using Cygwin.
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-11464
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11464
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: bin
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-11464-branch-2.001.patch, 
> HADOOP-11464-branch-2.002.patch, HADOOP-11464-branch-2.003.patch, 
> HADOOP-11464.001.patch, HADOOP-11464.002.patch, HADOOP-11464.003.patch
>
>
> The Windows compatibility work removed the dependency on Cygwin as a 
> compatibility layer.  However, some users may still wish to run Cygwin on a 
> personal machine for running Hadoop commands that interact with a cluster.  
> This issue proposes to reinstate support for launching Hadoop processes on 
> Windows using Cygwin to call the bash scripts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to