[
https://issues.apache.org/jira/browse/HADOOP-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278021#comment-14278021
]
Robert Kanter commented on HADOOP-8757:
---------------------------------------
Looks good. One minor thing: instead of allocating memory for a new array (via
{{.toCharArray()}}), can we loop through the {{String}} using {{.charAt(...)}}?
> Metrics should disallow names with invalid characters
> -----------------------------------------------------
>
> Key: HADOOP-8757
> URL: https://issues.apache.org/jira/browse/HADOOP-8757
> Project: Hadoop Common
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Todd Lipcon
> Assignee: Ray Chiang
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8757-01.patch, HADOOP-8757-02.patch
>
>
> Just spent a couple hours trying to figure out why a metric I added didn't
> show up in JMX, only to eventually realize it was because I had a whitespace
> in the property name. This didn't cause any errors to be logged -- the metric
> just didn't show up in JMX. We should check that the name is valid and log an
> error, or replace invalid characters with something like an underscore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
