[
https://issues.apache.org/jira/browse/HADOOP-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278321#comment-14278321
]
Hadoop QA commented on HADOOP-8757:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12692451/HADOOP-8757.003.patch
against trunk revision 5805dc0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5408//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5408//console
This message is automatically generated.
> Metrics should disallow names with invalid characters
> -----------------------------------------------------
>
> Key: HADOOP-8757
> URL: https://issues.apache.org/jira/browse/HADOOP-8757
> Project: Hadoop Common
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Todd Lipcon
> Assignee: Ray Chiang
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8757-01.patch, HADOOP-8757-02.patch,
> HADOOP-8757.003.patch
>
>
> Just spent a couple hours trying to figure out why a metric I added didn't
> show up in JMX, only to eventually realize it was because I had a whitespace
> in the property name. This didn't cause any errors to be logged -- the metric
> just didn't show up in JMX. We should check that the name is valid and log an
> error, or replace invalid characters with something like an underscore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
