[
https://issues.apache.org/jira/browse/HADOOP-11602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323544#comment-14323544
]
Akira AJISAKA commented on HADOOP-11602:
----------------------------------------
Thanks [~ozawa] for the report and the patch. Mostly looks good to me. Two
minor nits:
{code}
import java.util.Deque;
+import java.util.Locale;
import org.apache.hadoop.fs.GlobPattern;
{code}
Would you move this up one line?
{code}
- returned.getState().toString(), queueInfo.getQueueState().toString().toLo
+ returned.getState().toString(),
+ queueInfo.getQueueState().toString().toLowerCase( Locale.ENGLISH));
{code}
{{( Locale.ENGLISH)}} should be {{(Locale.ENGLISH)}}.
In addition, would you please write a description why we need to set the locale?
Findbugs warnings and test failures look unrelated to the patch.
* TestJobConf : MAPREDUCE-6223
* TestHighRamJob : MAPREDUCE-6234
* Findbugs warnings (mapreduce-client-core) : MAPREDUCE-6225
* Findbugs warnings (yarn-server-resourcemanager) : YARN-3204
* Findbugs warnings (maven-plugins) : HADOOP-10478
> Fix toUpperCase/toLowerCase to use Locale.ENGLISH
> -------------------------------------------------
>
> Key: HADOOP-11602
> URL: https://issues.apache.org/jira/browse/HADOOP-11602
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: Tsuyoshi OZAWA
> Assignee: Tsuyoshi OZAWA
> Attachments: HADOOP-11602-001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
