[
https://issues.apache.org/jira/browse/HADOOP-11602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326479#comment-14326479
]
Akira AJISAKA commented on HADOOP-11602:
----------------------------------------
Looks good to me, +1. TestHighRamJob failure was fixed by MAPREDUCE-6234, and
TestJobConf failure is reported by MAPREDUCE-6223, so these failures are
unrelated to the patch. I grepped source code by the below command and
confirmed there is no place calling
{{String.toUpperCase}}/{{String.toLowerCase}} without specifying
{{Locale.ENGLISH}} or {{Locale.US}}.
{code}
$ find . -name "*.java" | xargs grep "\.toLowerCase(\|\.toUpperCase(" | grep -v
"Locale\.US\|Locale\.ENGLISH\|Character\.toUpperCase"
{code}
> Fix toUpperCase/toLowerCase to use Locale.ENGLISH
> -------------------------------------------------
>
> Key: HADOOP-11602
> URL: https://issues.apache.org/jira/browse/HADOOP-11602
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: Tsuyoshi OZAWA
> Assignee: Tsuyoshi OZAWA
> Attachments: HADOOP-11602-001.patch, HADOOP-11602-002.patch
>
>
> String#toLowerCase()/toUpperCase() without a locale argument can occur
> unexpected behavior based on the locale. It's written in
> [Javadoc|http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#toLowerCase()]:
> {quote}
> For instance, "TITLE".toLowerCase() in a Turkish locale returns "t\u0131tle",
> where '\u0131' is the LATIN SMALL LETTER DOTLESS I character
> {quote}
> This issue is derived from HADOOP-10101.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
