[
https://issues.apache.org/jira/browse/HADOOP-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333664#comment-14333664
]
Gera Shegalov commented on HADOOP-11619:
----------------------------------------
Thanks for updating the patch [~brahmareddy]! The logic in 004 looks good.
Please fix these code style nits:
In {{fs.ftp.FTPFileSystem}} add a line break before
{code}
@Override
public void initialize(URI uri, Configuration conf) throws IOException { //
get
{code}
In {{fs.ftp.TestFTPFileSystem}} use the 2-space indentation.
Per [HowToContribute wiki|http://wiki.apache.org/hadoop/HowToContribute]:
bq. Code must be formatted according to Sun's conventions, with one exception:
Indent two spaces per level, not four.
> FTPFileSystem should override getDefaultPort
> --------------------------------------------
>
> Key: HADOOP-11619
> URL: https://issues.apache.org/jira/browse/HADOOP-11619
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.6.0
> Reporter: Gera Shegalov
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-11619-002.patch, HADOOP-11619-003.patch,
> HADOOP-11619-004.patch, HADOOP-11619.patch
>
>
> FTPFileSystem should override FileSystem#getDefaultPort to return
> FTP.DEFAULT_PORT
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
