[
https://issues.apache.org/jira/browse/HADOOP-11620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337535#comment-14337535
]
Andrew Wang commented on HADOOP-11620:
--------------------------------------
{code}
for (int idx = currPos; idx != endPos; idx = (idx + 1) % providers.length) {
KMSClientProvider provider = providers[idx];
{code}
This is a nit, but I think this would be more clear like:
{code}
for (int i = 0; i < providers.length; i++) {
KMSClientProvider provider = provider[(currPos+i) % providers.length];
{code}
It looks good though, I'm +1 pending either way. Up to you if you want to
change the above.
> Add Support for Load Balancing across a group of KMS servers for HA
> -------------------------------------------------------------------
>
> Key: HADOOP-11620
> URL: https://issues.apache.org/jira/browse/HADOOP-11620
> Project: Hadoop Common
> Issue Type: Improvement
> Components: kms
> Affects Versions: 2.6.0
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: HADOOP-11620.1.patch, HADOOP-11620.2.patch,
> HADOOP-11620.3.patch, HADOOP-11620.4.patch, HADOOP-11620.5.patch,
> HADOOP-11620.6.patch
>
>
> This patch needs to add support for :
> * specification of multiple hostnames in the kms key provider uri
> * KMS client to load balance requests across the hosts specified in the kms
> keyprovider uri.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
