[
https://issues.apache.org/jira/browse/HADOOP-11669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346803#comment-14346803
]
Hadoop QA commented on HADOOP-11669:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12702442/0001-HDFS-7883.patch
against trunk revision 3560180.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5843//console
This message is automatically generated.
> Move the Hadoop constants in HTTPServer.java to CommonConfigurationKeys class
> -----------------------------------------------------------------------------
>
> Key: HADOOP-11669
> URL: https://issues.apache.org/jira/browse/HADOOP-11669
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: nijel
> Assignee: nijel
> Priority: Minor
> Attachments: 0001-HDFS-7883.patch
>
>
> These 2 configurations in HttpServer2.java is hadoop configurations.
> {code}
> static final String FILTER_INITIALIZER_PROPERTY
> = "hadoop.http.filter.initializers";
> public static final String HTTP_MAX_THREADS = "hadoop.http.max.threads";
> {code}
> It is better to keep it inside CommonConfigurationKeys
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
