[
https://issues.apache.org/jira/browse/HADOOP-11669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347107#comment-14347107
]
Hadoop QA commented on HADOOP-11669:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12702457/001-HADOOP-11669.patch
against trunk revision 3560180.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5844//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5844//console
This message is automatically generated.
> Move the Hadoop constants in HTTPServer.java to CommonConfigurationKeys class
> -----------------------------------------------------------------------------
>
> Key: HADOOP-11669
> URL: https://issues.apache.org/jira/browse/HADOOP-11669
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: nijel
> Assignee: nijel
> Priority: Minor
> Attachments: 0001-HDFS-7883.patch, 001-HADOOP-11669.patch
>
>
> These 2 configurations in HttpServer2.java is hadoop configurations.
> {code}
> static final String FILTER_INITIALIZER_PROPERTY
> = "hadoop.http.filter.initializers";
> public static final String HTTP_MAX_THREADS = "hadoop.http.max.threads";
> {code}
> It is better to keep it inside CommonConfigurationKeys
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
