[
https://issues.apache.org/jira/browse/HADOOP-11638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349257#comment-14349257
]
Colin Patrick McCabe commented on HADOOP-11638:
-----------------------------------------------
bq. Dmitry asked: Why not to include the whole patch from wine you provided?
There are efforts on porting hadoop to Solaris at least, which would
automatically benefit from this.
We cannot use code from Wine because Wine is under some flavor of the GPL.
This is class X license according to Apache. (See
http://www.apache.org/legal/resolved.html )
bq. Allen said: I really really hope someone checked the license on that code
before they contaminated all of us.
This patch isn't a copy-paste of the code from Wine. You can see that the Wine
code uses {{thr_self}}, whereas this code uses {{pthread_getthreadid_np}}.
I am +1 on 002. Will commit in a few hours if there's no more comments.
Thanks guys
> Linux-specific gettid() used in OpensslSecureRandom.c
> -----------------------------------------------------
>
> Key: HADOOP-11638
> URL: https://issues.apache.org/jira/browse/HADOOP-11638
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.6.0
> Reporter: Dmitry Sivachenko
> Assignee: Kiran Kumar M R
> Labels: freebsd
> Attachments: HADOOP-11638-001.patch, HADOOP-11638-002.patch
>
>
> In OpensslSecureRandom.c you use Linux-specific syscall gettid():
> static unsigned long pthreads_thread_id(void)
> {
> return (unsigned long)syscall(SYS_gettid);
> }
> Man page says:
> gettid() is Linux-specific and should not be used in programs that are
> intended to be portable.
> This breaks hadoop-2.6.0 compilation on FreeBSD (may be on other OSes too).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
