[
https://issues.apache.org/jira/browse/HADOOP-11638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350803#comment-14350803
]
Dan McGregor commented on HADOOP-11638:
---------------------------------------
Casting the return value of pthread_getthreadid_np may be lossy. FreeBSD uses
an unsigned long for thread IDs, but that function casts it to an int.
FreeBSD's pthread_t is a pointer to a structure whose first member is the
thread id, so:
thread_id = *(unsigned long *)pthread_self();
may be what is wanted. My concern about this, though, is that it's relying on
undocumented implementation details.
> Linux-specific gettid() used in OpensslSecureRandom.c
> -----------------------------------------------------
>
> Key: HADOOP-11638
> URL: https://issues.apache.org/jira/browse/HADOOP-11638
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.6.0
> Reporter: Dmitry Sivachenko
> Assignee: Kiran Kumar M R
> Labels: freebsd
> Attachments: HADOOP-11638-001.patch, HADOOP-11638-002.patch,
> HADOOP-11638-003.patch
>
>
> In OpensslSecureRandom.c you use Linux-specific syscall gettid():
> static unsigned long pthreads_thread_id(void)
> {
> return (unsigned long)syscall(SYS_gettid);
> }
> Man page says:
> gettid() is Linux-specific and should not be used in programs that are
> intended to be portable.
> This breaks hadoop-2.6.0 compilation on FreeBSD (may be on other OSes too).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
