[ 
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-11746:
-----------------------------------
    Hadoop Flags: Incompatible change,Reviewed  (was: Incompatible change)

+1 for patch v16.  All of my feedback has been addressed either by code changes 
or explaining parts of the logic that I misunderstood.

Since this impacts everyone's day-to-day work, can we please hold off 
committing until Friday, 4/17, just in case there are other opinions?  I'll 
send notice now to the dev lists.

I have just one more procedural question.  I see this is flagged as an 
incompatible change.  While that's technically true, I don't think 
compatibility concerns apply to our internal dev tooling.  If it's flagged as 
incompatible, then it may cause confusion for Hadoop end users who think they 
need to do something in their deployments to react to this incompatibility.  
What do you think?


> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, 
> HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, 
> HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, 
> HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, 
> HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch, 
> HADOOP-11746-15.patch, HADOOP-11746-16.patch
>
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to