[ 
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11866:
--------------------------------------
    Attachment: HADOOP-11866-checkstyle.patch

-checkstyle.patch:
* Here's a modified version of the checkstyle.sh plug-in. It still needs some 
work, but gets us most of the way there.

A few things:
* It looks like output.file doesn't actually work.  So I opted to play games 
with the console output. 
* New method written in shell to determine if there are actually new issues.  I 
think it works?
* Showing what is actually different is significantly harder than I thought it 
would be because of magically changing line numbers.  An sdiff -s output 
*might* be better here.  

Anyway, some code to play with and fill in the gaps if you want.

> increase readability of the output of white space and checkstyle script
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-11866
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11866
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Minor
>         Attachments: HADOOP-11866-checkstyle.patch, 
> HADOOP-11866.20150422-1.patch, HADOOP-11866.20150423-1.patch
>
>
> HADOOP-11746 supports listing of the lines which has trailing white spaces 
> but doesn't inform patch line number. Without this report output will not be 
> of much help as in most cases it reports blank lines. Also for the first 
> timers it would be difficult to understand the output check style script 
> hence adding an header



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to