[
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated HADOOP-11866:
--------------------------------------
Attachment: HADOOP-11866-05.patch
-05:
* added a new support file for plugins that gives a listing of files and lines
changed after the patch is applied
* fixed an issue with ${CHANGED_FILES} where extra cruft from the patch was
being added due to differences in how patches are formatted. This may have
resulted in some patches having tests run twice or even skipped.
* checkstyle errors are now calculated per module. this speeds up this
particular test quite a bit and means that it is less likely to NPE for certain
classes of patches.
*checkstyle now shows errors before, errors after, and the filename + line
number where the new errors are being reported. Unfortunately, this uses GNU
diff extensions. :(
* whitespace now prints the name and line of the source file that has the
whitespace
* fixed _all_ of the shellcheck errors. newer versions of shellcheck now
understand line continuations! So all those false reports triggered by awk are
now gone!
NOTE: I have a suspicion that the current checkstyle code in test-patch is
actually reporting the wrong number. Patches can trigger checkstyle errors
that appear outside of the lines that are patched. MAPREDUCE-6165, for
example, has only 1 reported, but there are actually 8 new ones. (4 were
removed by the patch.)
Given the aggravation, etc, these issues are causing, this should probably be
committed ASAP. If someone could do a quick test+review, that'd be great.
> increase readability of the output of white space and checkstyle script
> -----------------------------------------------------------------------
>
> Key: HADOOP-11866
> URL: https://issues.apache.org/jira/browse/HADOOP-11866
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Naganarasimha G R
> Assignee: Allen Wittenauer
> Priority: Minor
> Attachments: HADOOP-11866-05.patch, HADOOP-11866-checkstyle.patch,
> HADOOP-11866.20150422-1.patch, HADOOP-11866.20150423-1.patch,
> HADOOP-11866.20150427-1.patch
>
>
> HADOOP-11746 supports listing of the lines which has trailing white spaces
> but doesn't inform patch line number. Without this report output will not be
> of much help as in most cases it reports blank lines. Also for the first
> timers it would be difficult to understand the output check style script
> hence adding an header
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
