[
https://issues.apache.org/jira/browse/HADOOP-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525403#comment-14525403
]
Hadoop QA commented on HADOOP-9281:
-----------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 26s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 1s | The applied patch generated
14 new checkstyle issues (total was 0, now 14). |
| {color:red}-1{color} | checkstyle | 1m 25s | The applied patch generated
13 new checkstyle issues (total was 2, now 15). |
| {color:red}-1{color} | whitespace | 0m 1s | The patch has 41 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 2m 17s | The patch appears to introduce 1
new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | mapreduce tests | 0m 45s | Tests passed in
hadoop-mapreduce-client-common. |
| {color:green}+1{color} | mapreduce tests | 1m 35s | Tests passed in
hadoop-mapreduce-client-core. |
| | | 40m 6s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-mapreduce-client-core |
| | Write to static field
org.apache.hadoop.mapreduce.task.reduce.ShuffleClientMetrics.instanceCount from
instance method new
org.apache.hadoop.mapreduce.task.reduce.ShuffleClientMetrics(TaskAttemptID,
JobConf) At ShuffleClientMetrics.java:from instance method new
org.apache.hadoop.mapreduce.task.reduce.ShuffleClientMetrics(TaskAttemptID,
JobConf) At ShuffleClientMetrics.java:[line 70] |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12607402/HADOOP-9281-trunk--N6--MAPREDUCE-part.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6ae2a0d |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6404/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt
https://builds.apache.org/job/PreCommit-HADOOP-Build/6404/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6404/artifact/patchprocess/whitespace.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6404/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
|
| hadoop-mapreduce-client-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6404/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt
|
| hadoop-mapreduce-client-core test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6404/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6404/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6404/console |
This message was automatically generated.
> Rework all usages of o.a.h.metrics to o.a.h.metrics2 new metrics API
> --------------------------------------------------------------------
>
> Key: HADOOP-9281
> URL: https://issues.apache.org/jira/browse/HADOOP-9281
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.7
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Attachments: HADOOP-9281-branch-0.23--N5.patch,
> HADOOP-9281-trunk--N5.patch, HADOOP-9281-trunk--N6--HADOOP-COMMON-part.patch,
> HADOOP-9281-trunk--N6--MAPREDUCE-part.patch, HADOOP-9281-trunk--N6.patch
>
>
> The following done:
> 1) o.a.h.metrics.MetricsServlet reworked to o.a.h.metrics2.lib.MetricsServlet2
> 2) class org.apache.hadoop.mapreduce.task.reduce.ShuffleClientMetrics
> rewritten to use metrics2 API.
> 3) class org.apache.hadoop.mapred.LocalJobRunnerMetrics rewritten to use new
> metrics2 API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
