[
https://issues.apache.org/jira/browse/HADOOP-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525405#comment-14525405
]
Hadoop QA commented on HADOOP-10035:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 8s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 26s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 19s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 1s | There were no new checkstyle
issues. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 40s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:red}-1{color} | common tests | 21m 44s | Tests failed in
hadoop-common. |
| | | 39m 25s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.fs.TestFilterFileSystem |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12607893/HADOOP-10035.2.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / 6ae2a0d |
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6405/artifact/patchprocess/whitespace.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6405/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6405/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6405/console |
This message was automatically generated.
> Cleanup TestFilterFileSystem
> ----------------------------
>
> Key: HADOOP-10035
> URL: https://issues.apache.org/jira/browse/HADOOP-10035
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.1.1-beta
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-10035.1.patch, HADOOP-10035.2.patch,
> HADOOP-10035.patch
>
>
> Currently TestFilterFileSystem only checks for FileSystem methods that must
> be implemented in FilterFileSystem with a list of methods that are exception
> to this rule. This jira wants to make this check stricter by adding a test
> for ensuring the methods in exception rule list must not be implemented by
> the FilterFileSystem.
> This also cleans up the current class that has methods from exception rule
> list to interface to avoid having to provide dummy implementation of the
> methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
