[
https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535591#comment-14535591
]
Colin Patrick McCabe commented on HADOOP-7824:
----------------------------------------------
Hi [~alanbur], I like this approach. Best of both worlds. Just one comment:
would you consider doing {{import static NativeIO.Constants.O_WRONLY}} at the
top of these files, to avoid having to type out
{{NativeIO.Constants.O_WRONLY}}, etc. later on?
{code}
19 #define _GNU_SOURCE
{code}
Shouldn't be needed, as {{CMakeLists.txt}} will set this.
{code}
73 if (const_name == NULL) return 0; // JVM throws Exception
{code}
Should use braces.
+1 pending those fixes and pending jenkins
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
> Key: HADOOP-7824
> URL: https://issues.apache.org/jira/browse/HADOOP-7824
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0, 2.0.0-alpha, 3.0.0
> Environment: Mac OS X, Linux, Solaris, Windows, ...
> Reporter: Dmytro Shteflyuk
> Assignee: Todd Lipcon
> Labels: hadoop
> Attachments: HADOOP-7824.patch, HADOOP-7824.patch, hadoop-7824.txt
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many
> other operating systems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
