[ 
https://issues.apache.org/jira/browse/HADOOP-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616985#comment-14616985
 ] 

Ravi Prakash commented on HADOOP-12194:
---------------------------------------

Hi Andrew! It should be sufficient to check the modification time of the output 
directory, don't you think? I understand that has the downside that all protoc 
files will be compiled again, but how often do we change the protoc files in 
the first place?

Anyway, my build which I run as {{mvn -Pdist -Pnative -Dmaven.javadoc.skip 
-DskipTests install}} is failing with:
{code}
[ERROR] Failed to execute goal 
org.apache.hadoop:hadoop-maven-plugins:3.0.0-SNAPSHOT:protoc (compile-protoc) 
on project hadoop-yarn-api: java.io.FileNotFoundException: 
<my-source-code-directory>/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/server
 (Is a directory) -> [Help 1]
{code}
I did a git clean -fdx too. 

> Support for incremental generation in the protoc plugin
> -------------------------------------------------------
>
>                 Key: HADOOP-12194
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12194
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.6-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hadoop-12194.001.patch
>
>
> The protoc maven plugin currently generates new Java classes every time, 
> which means Maven always picks up changed files in the build. It would be 
> better if the protoc plugin only generated new Java classes when the source 
> protoc files change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to