[
https://issues.apache.org/jira/browse/HADOOP-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619074#comment-14619074
]
Andrew Wang commented on HADOOP-12194:
--------------------------------------
Hi Vinay, thanks for reviewing,
I think we're safe because we only write the new checksum file on success, it
acts like a "commit". Since the checksum file is stored in target, running a
"mvn clean" also wipes it out in case of any issues.
I'll commit shortly based on your +1, thanks again. The jenkins run looks
screwed up, no changes in the most recent patch besides the additional line
break.
> Support for incremental generation in the protoc plugin
> -------------------------------------------------------
>
> Key: HADOOP-12194
> URL: https://issues.apache.org/jira/browse/HADOOP-12194
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.6-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hadoop-12194.001.patch, hadoop-12194.002.patch,
> hadoop-12194.003.patch
>
>
> The protoc maven plugin currently generates new Java classes every time,
> which means Maven always picks up changed files in the build. It would be
> better if the protoc plugin only generated new Java classes when the source
> protoc files change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
