[
https://issues.apache.org/jira/browse/HADOOP-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617734#comment-14617734
]
Kengo Seki commented on HADOOP-11903:
-------------------------------------
Sorry for late reply, and thanks a lot everyone for reviews and comments. While
checkstyle is more concise and can investigate java sources more deeply, this
plugin is applicable to other filename checking cases than java. They cover
different usecases, so it is meaningful to add this functionality to yetus. And
for the purpose of checking only classnames, this functionality is enough.
Probably we should utilize checkstyle for more complicated verifications, such
as variable or method names.
bq. Shall we update the JIRA summary and pursue the more general case?
I'll update the jira summary to "test-patch plugin for file name conventions"
or something and the description also.
bq. Lots of things specific to java and classnames which would need to be
updated
I'm thinking of modifying this plugin more generic and renaming it to
"filename.sh" or something.
> test-patch should fail any new classes called Default-foo
> ---------------------------------------------------------
>
> Key: HADOOP-11903
> URL: https://issues.apache.org/jira/browse/HADOOP-11903
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Kengo Seki
> Attachments: HADOOP-11903.HADOOP-12111.00.patch
>
>
> In the past, we've named things like DefaultResourceCalculator,
> DefaultContainerExecutor, and DefaultCodec that do nothing but cause problems
> down the road since they are effectively version and functionality locked
> forever. If these examples had been named what they truly were (e.g.,
> MemoryResourceCalculator, SimpleContainerExecutor, and GZipCodec), the
> defaults could then be changed in the future in a compatible way.
> One way to enforce this is to prevent the creation of new classes called
> Default-anything.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
