[ 
https://issues.apache.org/jira/browse/HADOOP-10854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632303#comment-14632303
 ] 

Kengo Seki commented on HADOOP-10854:
-------------------------------------

Great improvement for shell script quality assurance. Though I haven't read the 
entire code yet, some comments:

* In run-bats.sh, is "mkdir -p $\{dir}/surefire-reports" a mistake for ”mkdir 
-p $\{dir}?” surefire-reports/surefire-reports seems always empty.
* Can we include tap-to-junit-xml to our codebase in terms of the license?


> unit tests for the shell scripts
> --------------------------------
>
>                 Key: HADOOP-10854
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10854
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: scripts
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>              Labels: scripts
>         Attachments: HADOOP-10854.00.patch
>
>
> With HADOOP-9902 moving a lot of the core functionality to functions, we 
> should build some unit tests for them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to