[
https://issues.apache.org/jira/browse/HADOOP-12204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12204:
--------------------------------
Attachment: HADOOP-12204.HADOOP-12111.00.patch
Attaching a wip patch. Pylint result before this patch applied:
{code}
[sekikn@mobile hadoop]$ pylint --indent-string=" "
dev-support/releasedocmaker.py
(snip)
Global evaluation
-----------------
Your code has been rated at 2.29/10 (previous run: 2.29/10, +0.00)
{code}
And after:
{code}
[sekikn@mobile hadoop]$ pylint --indent-string=" "
dev-support/releasedocmaker.py
(snip)
Global evaluation
-----------------
Your code has been rated at 8.99/10 (previous run: 2.29/10, +6.70)
{code}
Remaining warnings are as follows. (I'm tempted to accept these ones...)
{code}
C:124, 0: Line too long (103/100) (line-too-long)
C:375, 0: Line too long (105/100) (line-too-long)
C:499, 0: Line too long (112/100) (line-too-long)
C:513, 0: Line too long (101/100) (line-too-long)
C: 1, 0: Missing module docstring (missing-docstring)
F: 30, 2: Unable to import 'simplejson' (import-error)
C: 55, 0: Missing function docstring (missing-docstring)
C: 58, 0: Missing function docstring (missing-docstring)
C: 70, 0: Missing function docstring (missing-docstring)
C: 82, 0: Missing function docstring (missing-docstring)
C: 92, 0: Missing function docstring (missing-docstring)
C: 98, 0: Missing function docstring (missing-docstring)
C:103, 0: Missing function docstring (missing-docstring)
C:133, 2: Missing method docstring (missing-docstring)
R:115, 0: Too few public methods (1/2) (too-few-public-methods)
R:136, 0: Too few public methods (0/2) (too-few-public-methods)
C:168, 2: Missing method docstring (missing-docstring)
C:171, 2: Missing method docstring (missing-docstring)
C:174, 2: Missing method docstring (missing-docstring)
C:183, 2: Missing method docstring (missing-docstring)
C:190, 2: Missing method docstring (missing-docstring)
C:197, 2: Missing method docstring (missing-docstring)
C:203, 2: Missing method docstring (missing-docstring)
C:206, 2: Missing method docstring (missing-docstring)
C:213, 2: Missing method docstring (missing-docstring)
C:220, 2: Missing method docstring (missing-docstring)
C:240, 2: Missing method docstring (missing-docstring)
C:254, 2: Missing method docstring (missing-docstring)
C:259, 2: Missing method docstring (missing-docstring)
C:264, 2: Missing method docstring (missing-docstring)
C:272, 2: Missing method docstring (missing-docstring)
R:281, 2: Too many local variables (16/15) (too-many-locals)
C:325, 2: Missing method docstring (missing-docstring)
R:278, 0: Too few public methods (1/2) (too-few-public-methods)
C:344, 2: Missing method docstring (missing-docstring)
C:353, 2: Missing method docstring (missing-docstring)
C:358, 2: Missing method docstring (missing-docstring)
C:363, 2: Missing method docstring (missing-docstring)
C:374, 0: Missing function docstring (missing-docstring)
R:374, 0: Too many local variables (33/15) (too-many-locals)
R:374, 0: Too many branches (32/12) (too-many-branches)
R:374, 0: Too many statements (147/50) (too-many-statements)
{code}
> releasedocmaker should pass pylint
> ----------------------------------
>
> Key: HADOOP-12204
> URL: https://issues.apache.org/jira/browse/HADOOP-12204
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Reporter: Chris Nauroth
> Priority: Minor
> Attachments: HADOOP-12204.HADOOP-12111.00.patch
>
>
> releasedocmaker.py currently uses a mix of 2-space and 4-space indentation.
> It would be good to make this consistent for readability.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
