[
https://issues.apache.org/jira/browse/HADOOP-12204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12204:
--------------------------------
Attachment: HADOOP-12204.HADOOP-12111.01.patch
Rebased the patch and fixed the indentation. Finally, pylint result is as
follows:
{code}
[sekikn@mobile hadoop]$ pylint dev-support/releasedocmaker.py
No config file found, using default configuration
************* Module releasedocmaker
C:381, 0: Line too long (107/100) (line-too-long)
C: 1, 0: Missing module docstring (missing-docstring)
F: 30, 4: Unable to import 'simplejson' (import-error)
C: 55, 0: Missing function docstring (missing-docstring)
C: 58, 0: Missing function docstring (missing-docstring)
C: 70, 0: Missing function docstring (missing-docstring)
C: 82, 0: Missing function docstring (missing-docstring)
C: 92, 0: Missing function docstring (missing-docstring)
C: 98, 0: Missing function docstring (missing-docstring)
C:103, 0: Missing function docstring (missing-docstring)
C:135, 4: Missing method docstring (missing-docstring)
R:115, 0: Too few public methods (1/2) (too-few-public-methods)
R:138, 0: Too few public methods (0/2) (too-few-public-methods)
C:170, 4: Missing method docstring (missing-docstring)
C:173, 4: Missing method docstring (missing-docstring)
C:176, 4: Missing method docstring (missing-docstring)
C:185, 4: Missing method docstring (missing-docstring)
C:192, 4: Missing method docstring (missing-docstring)
C:199, 4: Missing method docstring (missing-docstring)
C:205, 4: Missing method docstring (missing-docstring)
C:208, 4: Missing method docstring (missing-docstring)
C:215, 4: Missing method docstring (missing-docstring)
C:222, 4: Missing method docstring (missing-docstring)
C:242, 4: Missing method docstring (missing-docstring)
C:256, 4: Missing method docstring (missing-docstring)
C:261, 4: Missing method docstring (missing-docstring)
C:266, 4: Missing method docstring (missing-docstring)
C:274, 4: Missing method docstring (missing-docstring)
R:284, 4: Too many local variables (19/15) (too-many-locals)
C:330, 4: Missing method docstring (missing-docstring)
R:281, 0: Too few public methods (1/2) (too-few-public-methods)
C:349, 4: Missing method docstring (missing-docstring)
C:358, 4: Missing method docstring (missing-docstring)
C:363, 4: Missing method docstring (missing-docstring)
C:368, 4: Missing method docstring (missing-docstring)
C:380, 0: Missing function docstring (missing-docstring)
R:380, 0: Too many local variables (33/15) (too-many-locals)
R:380, 0: Too many branches (31/12) (too-many-branches)
R:380, 0: Too many statements (145/50) (too-many-statements)
(snip)
Global evaluation
-----------------
Your code has been rated at 9.08/10 (previous run: 9.08/10, +0.00)
{code}
Removing '--indent-string=" "' from the pylint plugin may conflict with
HADOOP-12266, so I'll wait for it to be committed.
> releasedocmaker should pass pylint
> ----------------------------------
>
> Key: HADOOP-12204
> URL: https://issues.apache.org/jira/browse/HADOOP-12204
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Reporter: Chris Nauroth
> Assignee: Kengo Seki
> Priority: Minor
> Attachments: HADOOP-12204.HADOOP-12111.00.patch,
> HADOOP-12204.HADOOP-12111.01.patch
>
>
> releasedocmaker.py currently uses a mix of 2-space and 4-space indentation.
> It would be good to make this consistent for readability.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
