[
https://issues.apache.org/jira/browse/HADOOP-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652664#comment-14652664
]
Sean Busbey commented on HADOOP-12247:
--------------------------------------
+1
nits:
{code}
+ # shellcheck disable=2016
{code}
should be {{# shellcheck disable=SC2016}} ?
{code}
+ JUNIT_FAILED_TESTS="${JUNIT_FAILED_TESTS} ${module_failed_tests}"
...SNIP...
+ # shellcheck disable=SC2086
+ populate_test_table "${jdk}Failed junit tests" ${JUNIT_FAILED_TESTS}
{code}
We could be using arrays to avoid needing a shellcheck disable here, I think?
We do this in plenty of places, so I don't think it needs to get fixed in this
patch.
> Convert 'unit' to 'junit'
> -------------------------
>
> Key: HADOOP-12247
> URL: https://issues.apache.org/jira/browse/HADOOP-12247
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: HADOOP-12247.HADOOP-12111.00.patch,
> HADOOP-12247.HADOOP-12111.01.patch
>
>
> In order to support other unit test systems, we should convert 'unit' to be
> specifically 'junit'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
