[
https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698119#comment-14698119
]
Sean Busbey commented on HADOOP-12129:
--------------------------------------
{noformat}
+
+* pluginname_writecomment
+
+ - Given text input, write this output to the bug system as a comment.
NOTE: It is the bug system's responsibility to format appropriately.
+
+* pluginname\_linecomments
+
+ - This function allows for the system to write specific comments on
specific lines if the bug system supports code review comments.
+
+* pluginname_finalreport
+
{noformat}
the first and second bullet points should use \ to escape the _
{noformat}
-* ISSUE\_RE is to help test-patch when talking to JIRA. It helps determine if
the given project is appropriate for the given JIRA issue.
+* JIRA\_ISSUE\_RE is to help test-patch when talking to JIRA. It helps
determine if the given project is appropriate for the given JIRA issue. There
are similar variables for GITHUB.
{noformat}
Give a pointer to the variable or say what it is? It's GITHUB_ISSUE, and
without other context this paragraph would have made me presume GITHUB_ISSUE_RE.
{noformat}
-* wget
+* curl
{noformat}
yay! :)
{noformat}
+
+A new practice within the ASF is to use a service such as GitHub and its Pull
Request (PR) feature. test-patch supports many forms of providing PR support.
+
{noformat}
nit: I don't think we need to mention the ASF use here, since our goal is
larger.
{noformat}
+ ${CURL} --silent \
+ --output "${PATCH_DIR}/jira" \
+ --location \
+ "http://issues.apache.org/jira/browse/${PATCH_OR_ISSUE}";
{noformat}
nit: maybe different issue. can we just start at the https url? also maybe we
need some link about setting up https support for curl. and maybe a warning
that you should trust your issue tracker since we use --location (though this
is very minor, given our broader context).
{noformat}
+# personalities can override the following settings:
+
+# Web interface URL.
+GITHUB_BASE_URL="https://github.com";
+
+# API interface URL.
+GITHUB_API_URL="https://api.github.com";
+
{noformat}
does this mean we can support github enterprise installations?!
(looks like barring the note about jira issues that point at github. sweet)
> rework test-patch bug system support
> ------------------------------------
>
> Key: HADOOP-12129
> URL: https://issues.apache.org/jira/browse/HADOOP-12129
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: HADOOP-12129.HADOOP-12111.00.patch,
> HADOOP-12129.HADOOP-12111.01.patch, HADOOP-12129.HADOOP-12111.02.patch,
> HADOOP-12129.HADOOP-12111.03.patch, HADOOP-12129.HADOOP-12111.04.patch
>
>
> WARNING: this is a fairly big project.
> See first comment for a brain dump on the issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
