[
https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698378#comment-14698378
]
Allen Wittenauer commented on HADOOP-12129:
-------------------------------------------
bq. Give a pointer to the variable or say what it is? It's GITHUB_ISSUE, and
without other context this paragraph would have made me presume GITHUB_ISSUE_RE.
Good catch, especially since GITHUB_ISSUE_RE doesn't exist anymore. (It did
when I wrote that.) Specifically called out GITHUB_REPO which is the functional
replacement.
bq. maybe different issue. can we just start at the https url?
Yes, we should.
bq. also maybe we need some link about setting up https support for curl. and
maybe a warning that you should trust your issue tracker since we use
--location (though this is very minor, given our broader context).
Well, that particular code is for smart-apply-patch and specifically hard-coded
to the ASF jira. De-Apache-ing smart-apply-patch to point to another JIRA
system and add GH support, etc, is a different project for sure. At some point,
we need to tie smart-apply-patch into test-patch's plugin code. As long as we
keep teasing code out of test-patch, this will get easier and easier to do.
bq. does this mean we can support github enterprise installations?! (looks like
barring the note about jira issues that point at github. sweet)
Someone needs to test it, but yes, I think I've gotten the necessary plumbing
in place to support it.
bq. can we add a flag that picks one and defaults to "all"?
Add --bugcomments. It takes a list but one always gets the console.
> rework test-patch bug system support
> ------------------------------------
>
> Key: HADOOP-12129
> URL: https://issues.apache.org/jira/browse/HADOOP-12129
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: HADOOP-12129.HADOOP-12111.00.patch,
> HADOOP-12129.HADOOP-12111.01.patch, HADOOP-12129.HADOOP-12111.02.patch,
> HADOOP-12129.HADOOP-12111.03.patch, HADOOP-12129.HADOOP-12111.04.patch
>
>
> WARNING: this is a fairly big project.
> See first comment for a brain dump on the issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
