[
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14732415#comment-14732415
]
Kengo Seki commented on HADOOP-4258:
------------------------------------
Thanks [~jagadesh.kiran], some comments:
* K and L are not so readable too. How about "$first", "$second" or something?
Also, $a and $b should be changed, like "$first_lower", "$second_lower".
* Address other Allen's comments. About test-patch plugin hooks such as
postcheckout or preapply, see [yetus precommit
document|https://github.com/apache/hadoop/blob/HADOOP-12111/dev-support/docs/precommit-advanced.md#test-plug-ins].
* This code
{code}
34 declare -a changed_files
35 i=0
36 # shellcheck disable=SC2153
37 while read line; do
38 changed_files[${i}]="${line}"
39 ((i=i+1))
40 done < <(echo "${CHANGED_FILES}")
{code}
is intended to store newline-separated strings in an array, but very verbose
(sorry, my fault). Instead,
{code}
declare -a changed_files
changed_files=(${CHANGED_FILES})
{code}
should work.
* And, please don't forget to shorten the plugin name. ;)
> the test patch script should check for filenames that differ only in case
> -------------------------------------------------------------------------
>
> Key: HADOOP-4258
> URL: https://issues.apache.org/jira/browse/HADOOP-4258
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
> Reporter: Owen O'Malley
> Assignee: Jagadesh Kiran N
> Labels: test-patch
> Attachments: HADOOP-4258.001.patch, HADOOP-4258.HADOOP-12111.00.patch
>
>
> It would be nice if the test patch script warned about filenames that differ
> only in case. We recently had a patch committed that had a pair of colliding
> filenames and subversion broke badly on my Mac.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
