[
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746778#comment-14746778
]
Kengo Seki commented on HADOOP-4258:
------------------------------------
Thanks [~jagadesh.kiran], some comments:
* Shortening only the filename is not sufficient. We must shorten
"duplicatednames" in the file, because the arguement of add_test is used as the
plugin name. See [Yetus precommit document about plugin
name|https://github.com/apache/hadoop/blob/HADOOP-12111/dev-support/docs/precommit-advanced.md#common-plug-in-functions].
* The following is probably different from what Allen originally meant. This
just sorts changed_files, while {{uniq -id}} outputs only duplicated lines
ignoring case.
{code}
IFS=$'\n' changed_files=($(sort --ignore-case <<<"${CHANGED_FILES[*]}"))
{code}
* The following line will fail because the closing brace is missing.
{code}
for ((j=i+1; j < ${#changed_files[@]; j++)) {
{code}
* Address shellcheck and whitespace warnings.
To make sure, the comments which are not addressed in this patch, except for
mentioned above:
bq. the problem that Owen O'Malley is actually talking about is a problem where
a new file was added because it conflicted with a pre-existing file in the
source tree. This patch would miss that situation.
bq. $a and $b should be changed, like "$first_lower", "$second_lower".
bq. if HADOOP-12257 gets committed, this should use _precheck instead of
_postcheckout.
> the test patch script should check for filenames that differ only in case
> -------------------------------------------------------------------------
>
> Key: HADOOP-4258
> URL: https://issues.apache.org/jira/browse/HADOOP-4258
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
> Reporter: Owen O'Malley
> Assignee: Jagadesh Kiran N
> Labels: test-patch
> Attachments: HADOOP-4258.001.patch,
> HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch
>
>
> It would be nice if the test patch script warned about filenames that differ
> only in case. We recently had a patch committed that had a pair of colliding
> filenames and subversion broke badly on my Mac.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
