[
https://issues.apache.org/jira/browse/HADOOP-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736852#comment-14736852
]
Kengo Seki commented on HADOOP-12257:
-------------------------------------
In addition to Sean's comments, I ran the updated test-patch for all 9 projects
currently supported, and confirmed the results correctly reflect the problems
which the patches have. Here's some examples.
BigTop:
{code}
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| -1 | test4tests | 0m 00s | The patch doesn't appear to include any
| | | | new or modified tests. Please justify why
| | | | no new tests are needed for this patch.
| | | | Also please list what manual steps were
| | | | performed to verify this patch.
| +1 | gradleboot | 0m 16s | master passed
| +1 | compile | 0m 09s | master passed
| -1 | scaladoc | 0m 09s | root in master failed.
| +1 | gradleboot | 0m 14s | the patch passed
| +1 | compile | 0m 10s | the patch passed
| +1 | scalac | 0m 10s | the patch passed
| +1 | whitespace | 0m 00s | Patch has no whitespace issues.
| -1 | scaladoc | 0m 10s | root in the patch failed.
| -1 | asflicense | 0m 10s | root in the patch failed.
| | | 1m 47s |
|| Subsystem || Report/Notes ||
============================================================================
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12754699/BIGTOP-2019.1.patch |
| JIRA Issue | BIGTOP-2019 |
| git revision | master / 5efdbfb |
| Optional Tests | asflicense scalac scaladoc unit compile |
| uname | Darwin mobile.local 14.5.0 Darwin Kernel Version 14.5.0: Wed Jul 29
02:26:53 PDT 2015; root:xnu-2782.40.9~1/RELEASE_X86_64 x86_64 |
| Build tool | gradle |
| Personality | /Users/sekikn/hadoop/dev-support/personality/bigtop.sh |
| Default Java | 1.7.0_80 |
| scaladoc | /private/tmp/test-patch-bigtop/19287/branch-scaladoc-root.txt |
| scaladoc | /private/tmp/test-patch-bigtop/19287/patch-scaladoc-root.txt |
| asflicense | /private/tmp/test-patch-bigtop/19287/patch-asflicense-root.txt |
{code}
Kafka: failed to compile
{code}
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 00s | The patch appears to include 11 new or
| | | | modified test files.
| +1 | gradleboot | 3m 47s | trunk passed
| +1 | compile | 20m 12s | trunk passed
| +1 | javadoc | 3m 37s | trunk passed
| +1 | scaladoc | 10m 01s | trunk passed
| +1 | gradleboot | 1m 55s | the patch passed
| -1 | compile | 10m 53s | root in the patch failed.
| -1 | javac | 10m 53s | root in the patch failed.
| -1 | scalac | 10m 53s | root in the patch failed.
| +1 | whitespace | 0m 01s | Patch has no whitespace issues.
| -1 | javadoc | 1m 09s | root in the patch failed.
| +1 | scaladoc | 2m 45s | the patch passed
| +1 | asflicense | 0m 55s | Patch does not generate ASF License
| | | | warnings.
| | | 62m 11s |
|| Subsystem || Report/Notes ||
============================================================================
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12754305/KAFKA-2120_2015-09-04_17%3A49%3A01.patch
|
| JIRA Issue | KAFKA-2120 |
| git revision | trunk / b8b1bca |
| Optional Tests | asflicense javac javadoc unit findbugs compile scalac
scaladoc |
| uname | Darwin mobile.local 14.5.0 Darwin Kernel Version 14.5.0: Wed Jul 29
02:26:53 PDT 2015; root:xnu-2782.40.9~1/RELEASE_X86_64 x86_64 |
| Build tool | gradle |
| Personality | /Users/sekikn/hadoop/dev-support/personality/kafka.sh |
| Default Java | 1.7.0_80 |
| compile | /private/tmp/test-patch-kafka/38835/patch-compile-root.txt |
| javac | /private/tmp/test-patch-kafka/38835/patch-compile-root.txt |
| scalac | /private/tmp/test-patch-kafka/38835/patch-compile-root.txt |
| findbugs | not supported by the gradle plugin |
| javadoc | /private/tmp/test-patch-kafka/38835/patch-javadoc-root.txt |
{code}
Samza: succeeded
{code}
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 00s | The patch appears to include 14 new or
| | | | modified test files.
| +1 | gradleboot | 1m 46s | master passed
| +1 | compile | 0m 57s | master passed
| +1 | javadoc | 17m 35s | master passed
| +1 | scaladoc | 7m 30s | master passed
| +1 | gradleboot | 2m 07s | the patch passed
| +1 | compile | 1m 43s | the patch passed
| +1 | javac | 1m 43s | the patch passed
| +1 | scalac | 1m 43s | the patch passed
| +1 | whitespace | 0m 00s | Patch has no whitespace issues.
| +1 | javadoc | 14m 14s | the patch passed
| +1 | scaladoc | 7m 31s | the patch passed
| +1 | asflicense | 2m 02s | Patch does not generate ASF License
| | | | warnings.
| | | 57m 10s |
|| Subsystem || Report/Notes ||
============================================================================
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12754774/SAMZA-619-1.patch |
| JIRA Issue | SAMZA-619 |
| git revision | master / 1aee39f |
| Optional Tests | asflicense javac javadoc unit findbugs compile scalac
scaladoc |
| uname | Darwin mobile.local 14.5.0 Darwin Kernel Version 14.5.0: Wed Jul 29
02:26:53 PDT 2015; root:xnu-2782.40.9~1/RELEASE_X86_64 x86_64 |
| Build tool | gradle |
| Personality | /Users/sekikn/hadoop/dev-support/personality/samza.sh |
| Default Java | 1.7.0_80 |
| findbugs | not supported by the gradle plugin |
{code}
One question: on BigTop, scaladoc and asflicense fail because they aren't
defined as gradle tasks. Can we regard it as a BigTop's issue, not a Yetus'? If
so, +1 (non-binding).
> rework build tool support; add gradle; add scala
> ------------------------------------------------
>
> Key: HADOOP-12257
> URL: https://issues.apache.org/jira/browse/HADOOP-12257
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: HADOOP-12257.HADOOP-12111.00.patch,
> HADOOP-12257.HADOOP-12111.01.patch, HADOOP-12257.HADOOP-12111.02.patch,
> HADOOP-12257.HADOOP-12111.03.patch, HADOOP-12257.HADOOP-12111.04.patch,
> HADOOP-12257.HADOOP-12111.05.patch
>
>
> We need to rework build tool support to be pluggable as well as add gradle
> support so that we cover more of the ecosystem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
