[
https://issues.apache.org/jira/browse/HADOOP-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737191#comment-14737191
]
Allen Wittenauer commented on HADOOP-12257:
-------------------------------------------
Sean:
bq. the plug-ins can also be provided by a user via command line, which I think
is worth mentioning. I'd be fine with fixing this in a follow on since it looks
like this isn't a part you actually changed.
Yeah, let's tackle this one later. This patch adds the building blocks to
delete tests, so I'd like to revisit how adding, removing, etc, from the
command line works entirely.... esp since we're more and more dependent upon
our .d directory for critical functions. I've got some ideas on what I'd like
to see. Filed HADOOP-12392.
bq."See the following sections for the documentation covering specific plug-in
types" would read better.
I was really trying hard to avoid creating Yet Another Index. haha. I'll
wordsmith it.
bq. What does "This plug-in type" mean here?
Ugh, yeah, that section is awkward. I'll play around with it.
bq. sometime we use plugin and sometimes we use plug-in. we should pick one.
Did some research and 'plugin-in' appears to be preferred for English. So I'll
do some work on replacing this everywhere outside of the APIs. (ugh! haha)
bq. Can we define a test-patch property for each of these, similar to how we
give maven users a profile activation?
I'm not sure I follow. Do you mean we always define something on the
mvn/gradle/ant command line so that the build system knows which mode we're in?
On one hand, the personality that runs the build system could actually do that,
but on the other that does mean extra code in the personality. Hmm. I suspect
this might be a bigger topic.
bq. how about: "Additional arguments should be handled via the personality;
notably we do not by default pass -DskipTests to compilation phases."
vs.
bq. I thought in the docs we said we didn't pass in -DskipTests? Was that just
in some specific category?
The docs are wrong. I was doing some research on what is legal maven and
discovered that skipTests is a maven thing, not a Hadoop thing like I always
thought it was. I'll remove that from the maven section.
bq. Worth a check for /usr/java/default or /usr/java/latest as a fallback for
e.g. CentOs / RHEL?
Probably, yes. I've opened HADOOP-12394 to track since there's a lot we could
do here. (this patch just moves the code, FWIW.)
bq. If we call this "compile_cycle" it'll line up better with what the
documentation calls it.
Good call. I'll change it.
----
Kengo:
bq. One question: on BigTop, scaladoc and asflicense fail because they aren't
defined as gradle tasks. Can we regard it as a BigTop's issue, not a Yetus'? If
so, +1 (non-binding).
[I'm assuming the patch you tested with actually did touch java and scala code.
If it didn't, then we've got a different set of bugs. :D ]
It really depends upon the approach that we want to take when projects don't
support all of our feature set. For features that really should be and are
easily supported (e.g., asflicense on maven and ant, scaladoc on gradle), I'm
inclined to let them fail to push the projects to add that support. For things
that aren't easily supported (e.g., asflicense on gradle, scaladoc on ant), for
*personalities* we ship we should probably disable until the projects can/do
take over their personality. Build systems should, by default, always run all
tests.
So IMO, bigtop's personality should probably not enqueue asflicense but still
fail on scaladoc given that they do ship scala code in their bigtop petstore
for spark. I
It's also worth noting that Kafka's asflicense passage is *false*. asflicense
has a fundamental flaw in its design. Filed HADOOP-12393.
> rework build tool support; add gradle; add scala
> ------------------------------------------------
>
> Key: HADOOP-12257
> URL: https://issues.apache.org/jira/browse/HADOOP-12257
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: HADOOP-12257.HADOOP-12111.00.patch,
> HADOOP-12257.HADOOP-12111.01.patch, HADOOP-12257.HADOOP-12111.02.patch,
> HADOOP-12257.HADOOP-12111.03.patch, HADOOP-12257.HADOOP-12111.04.patch,
> HADOOP-12257.HADOOP-12111.05.patch
>
>
> We need to rework build tool support to be pluggable as well as add gradle
> support so that we cover more of the ecosystem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
