[
https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-10775:
------------------------------------
Attachment: HADOOP-10775-004.patch
An iteration with
# cleanup of the tests: no need to skip symlink tests on windows
# small code review and some cleanup of Shell itself (-> SLF4J; why was the
{{AtomicBoolean}} {{completed}} marked as {{volatile?}}
# review of tests and switch to the exception raising {{getWinUtilsPathXXX()}}
calls.
# Improve {{NativeLibraryChecker}} to include text on windows as to why it
couldn't be found (and don't look when not on windows)
# if you try to get the path when not on windows, an exception gets raised.
# explicit calls to probe for the path existing, and to ask for it as a
{{File}} class.
> Shell operations to fail with meaningful errors on windows if winutils.exe
> not found
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-10775
> URL: https://issues.apache.org/jira/browse/HADOOP-10775
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: trunk-win, 2.7.1
> Environment: windows
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-10775-002.patch, HADOOP-10775-003.patch,
> HADOOP-10775-004.patch, HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other
> causes, then an error is logged -but when any of the {{Shell}} operations are
> used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before
> any attempt to invoke a winutils-driven process made
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
