[
https://issues.apache.org/jira/browse/HADOOP-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941429#comment-14941429
]
Hadoop QA commented on HADOOP-12122:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch | 0m 0s | The patch command could not apply
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12764793/HADOOP-12122-HADOOP-12122.3.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 439f43a |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7758/console |
This message was automatically generated.
> Fix Hadoop should avoid unsafe split and append on fields that might be IPv6
> literals
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-12122
> URL: https://issues.apache.org/jira/browse/HADOOP-12122
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HADOOP-11890
> Reporter: Nate Edel
> Assignee: Elliott Clark
> Attachments: HADOOP-12122-HADOOP-11890.0.patch,
> HADOOP-12122-HADOOP-12122.2.patch, HADOOP-12122-HADOOP-12122.3.patch,
> HADOOP-12122.0.patch, lets_blow_up_a_lot_of_tests.patch
>
>
> There are a fairly extensive number of locations found via code inspection
> which use unsafe methods of handling addresses in a dual-stack or IPv6-only
> world:
> - splits on the first ":" assuming that delimits a host from a port
> - produces a host port pair by appending :port blindly (Java prefers
> [ipv6]:port which is the standard for IPv6 URIs)
> - depends on the behavior of InetSocketAddress.toString() which produces the
> above.
> This patch fixes those metaphors that I can find above, and replaces calls to
> InetSocketAddress.toString() with a wrapper that properly brackets the IPv6
> address if there is one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
