[
https://issues.apache.org/jira/browse/HADOOP-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957490#comment-14957490
]
Hadoop QA commented on HADOOP-12122:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 22m 45s | Findbugs (version 3.0.0)
appears to be broken on HADOOP-11890. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 16 new or modified test files. |
| {color:green}+1{color} | javac | 7m 54s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 25s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 0m 16s | The applied patch generated
1 release audit warnings. |
| {color:red}-1{color} | checkstyle | 3m 32s | The applied patch generated 4
new checkstyle issues (total was 338, now 342). |
| {color:red}-1{color} | whitespace | 0m 19s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 29s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 15m 43s | The patch appears to introduce 7
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 7m 6s | Tests passed in
hadoop-common. |
| {color:red}-1{color} | mapreduce tests | 1m 42s | Tests failed in
hadoop-mapreduce-client-core. |
| {color:red}-1{color} | mapreduce tests | 5m 42s | Tests failed in
hadoop-mapreduce-client-hs. |
| {color:red}-1{color} | mapreduce tests | 0m 13s | Tests failed in
hadoop-mapreduce-client-jobclient. |
| {color:red}-1{color} | yarn tests | 0m 20s | Tests failed in
hadoop-yarn-common. |
| {color:green}+1{color} | yarn tests | 0m 24s | Tests passed in
hadoop-yarn-server-common. |
| {color:red}-1{color} | yarn tests | 0m 22s | Tests failed in
hadoop-yarn-server-nodemanager. |
| {color:red}-1{color} | yarn tests | 0m 23s | Tests failed in
hadoop-yarn-server-resourcemanager. |
| {color:green}+1{color} | yarn tests | 0m 22s | Tests passed in
hadoop-yarn-server-web-proxy. |
| {color:red}-1{color} | hdfs tests | 0m 23s | Tests failed in hadoop-hdfs. |
| {color:red}-1{color} | hdfs tests | 0m 19s | Tests failed in
hadoop-hdfs-client. |
| | | 81m 1s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-client |
| Failed unit tests | hadoop.mapred.TestJobEndNotifier |
| | hadoop.mapreduce.v2.hs.webapp.TestHsWebServices |
| | hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobConf |
| Failed build | hadoop-mapreduce-client-jobclient |
| | hadoop-yarn-common |
| | hadoop-yarn-server-nodemanager |
| | hadoop-yarn-server-resourcemanager |
| | hadoop-hdfs |
| | hadoop-hdfs-client |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12766589/HADOOP-12122-HADOOP-11890.7.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HADOOP-11890 / f33be9a |
| Release Audit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/whitespace.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-mapreduce-client-core test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
|
| hadoop-mapreduce-client-hs test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
|
| hadoop-mapreduce-client-jobclient test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
|
| hadoop-yarn-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-yarn-common.txt
|
| hadoop-yarn-server-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| hadoop-yarn-server-resourcemanager test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
|
| hadoop-yarn-server-web-proxy test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-yarn-server-web-proxy.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-client test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7812/console |
This message was automatically generated.
> Fix Hadoop should avoid unsafe split and append on fields that might be IPv6
> literals
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-12122
> URL: https://issues.apache.org/jira/browse/HADOOP-12122
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HADOOP-11890
> Reporter: Nate Edel
> Assignee: Nemanja Matkovic
> Attachments: HADOOP-12122-HADOOP-11890.0.patch,
> HADOOP-12122-HADOOP-11890.3.patch, HADOOP-12122-HADOOP-11890.4.patch,
> HADOOP-12122-HADOOP-11890.5.patch, HADOOP-12122-HADOOP-11890.6.patch,
> HADOOP-12122-HADOOP-11890.7.patch, HADOOP-12122-HADOOP-12122.2.patch,
> HADOOP-12122-HADOOP-12122.3.patch, HADOOP-12122.0.patch,
> lets_blow_up_a_lot_of_tests.patch
>
>
> There are a fairly extensive number of locations found via code inspection
> which use unsafe methods of handling addresses in a dual-stack or IPv6-only
> world:
> - splits on the first ":" assuming that delimits a host from a port
> - produces a host port pair by appending :port blindly (Java prefers
> [ipv6]:port which is the standard for IPv6 URIs)
> - depends on the behavior of InetSocketAddress.toString() which produces the
> above.
> This patch fixes those metaphors that I can find above, and replaces calls to
> InetSocketAddress.toString() with a wrapper that properly brackets the IPv6
> address if there is one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
