[ https://issues.apache.org/jira/browse/HADOOP-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958917#comment-14958917 ]
Elliott Clark commented on HADOOP-12122: ---------------------------------------- There's a ton of star imports. Can we get some ipv6 ip's in the tests that you had to change? > Fix Hadoop should avoid unsafe split and append on fields that might be IPv6 > literals > ------------------------------------------------------------------------------------- > > Key: HADOOP-12122 > URL: https://issues.apache.org/jira/browse/HADOOP-12122 > Project: Hadoop Common > Issue Type: Sub-task > Affects Versions: HADOOP-11890 > Reporter: Nate Edel > Assignee: Nemanja Matkovic > Attachments: HADOOP-12122-HADOOP-11890.0.patch, > HADOOP-12122-HADOOP-11890.3.patch, HADOOP-12122-HADOOP-11890.4.patch, > HADOOP-12122-HADOOP-11890.5.patch, HADOOP-12122-HADOOP-11890.6.patch, > HADOOP-12122-HADOOP-11890.7.patch, HADOOP-12122-HADOOP-11890.8.patch, > HADOOP-12122-HADOOP-12122.2.patch, HADOOP-12122-HADOOP-12122.3.patch, > HADOOP-12122.0.patch, lets_blow_up_a_lot_of_tests.patch > > > There are a fairly extensive number of locations found via code inspection > which use unsafe methods of handling addresses in a dual-stack or IPv6-only > world: > - splits on the first ":" assuming that delimits a host from a port > - produces a host port pair by appending :port blindly (Java prefers > [ipv6]:port which is the standard for IPv6 URIs) > - depends on the behavior of InetSocketAddress.toString() which produces the > above. > This patch fixes those metaphors that I can find above, and replaces calls to > InetSocketAddress.toString() with a wrapper that properly brackets the IPv6 > address if there is one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)