[ https://issues.apache.org/jira/browse/HADOOP-12472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975066#comment-14975066 ]
Jing Zhao commented on HADOOP-12472: ------------------------------------ oops, have not seen this comment before committing the patch. Maybe we can do this as a follow on? > Make GenericTestUtils.assertExceptionContains robust > ---------------------------------------------------- > > Key: HADOOP-12472 > URL: https://issues.apache.org/jira/browse/HADOOP-12472 > Project: Hadoop Common > Issue Type: Improvement > Components: test > Affects Versions: 3.0.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Minor > Fix For: 2.8.0 > > Attachments: HADOOP-12472-001.patch > > > {{GenericTestUtils.assertExceptionContains}} calls > {{Exception.getMessage()}}, followed by msg.contains(). > This will NPE for an exception with a null message, such as NPE. > # it should call toString() > # and do an assertNotNull on the result in case some subclass does something > very bad > # and for safety, check the asser -- This message was sent by Atlassian JIRA (v6.3.4#6332)