[
https://issues.apache.org/jira/browse/HADOOP-12472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975150#comment-14975150
]
Mingliang Liu commented on HADOOP-12472:
----------------------------------------
Thanks [~andrew.wang] and [~jingzhao] for pointing this out.
Yes it makes sense to make them package-private as they're for test purpose. I
filed [HADOOP-12514] to track this.
> Make GenericTestUtils.assertExceptionContains robust
> ----------------------------------------------------
>
> Key: HADOOP-12472
> URL: https://issues.apache.org/jira/browse/HADOOP-12472
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12472-001.patch
>
>
> {{GenericTestUtils.assertExceptionContains}} calls
> {{Exception.getMessage()}}, followed by msg.contains().
> This will NPE for an exception with a null message, such as NPE.
> # it should call toString()
> # and do an assertNotNull on the result in case some subclass does something
> very bad
> # and for safety, check the asser
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
