[
https://issues.apache.org/jira/browse/HADOOP-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001836#comment-15001836
]
Akira AJISAKA commented on HADOOP-12564:
----------------------------------------
Thanks [~cotedm] for cleaning up the test code. Two comments from me:
1. Public constructors can be removed from test class.
{code:title=TestArrayWritable.java}
public void testThrowUndefinedValueException() throws IOException {
{code}
{code:title=TestSequenceFile.java}
public void testInitZeroLengthSequenceFile() throws IOException {
{code}
2. These above two methods should be annotated by {{@Test}}.
> Upgrade JUnit3 TestCase to JUnit 4 for tests of org.apache.hadoop.io package
> ----------------------------------------------------------------------------
>
> Key: HADOOP-12564
> URL: https://issues.apache.org/jira/browse/HADOOP-12564
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Reporter: Dustin Cote
> Assignee: Dustin Cote
> Priority: Trivial
> Attachments: MAPREDUCE-6505-1.patch, MAPREDUCE-6505-2.patch,
> MAPREDUCE-6505-3.patch, MAPREDUCE-6505-4.patch, MAPREDUCE-6505-5.patch
>
>
> Migrating just the io test cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
