[
https://issues.apache.org/jira/browse/HADOOP-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005232#comment-15005232
]
Tsuyoshi Ozawa commented on HADOOP-12564:
-----------------------------------------
[~cote] Thank you for updating. We're almost there. In addition to Akira's
comment, please check following comments:
{code:title=TestSequenceFile.java|}
@Test
public void testCreateWriterOnExistingFile() throws IOException {
{code}
Please fix indentation(Please remote single whitespace before Test annotation).
{code:titile=TestVLong.java|}
@Test
public void testVLong6Bytes() throws IOException {
verifySixOrMoreBytes(6);
}
@Test
public void testVLong7Bytes() throws IOException {
verifySixOrMoreBytes(7);
}
@Test
public void testVLong8Bytes() throws IOException {
verifySixOrMoreBytes(8);
}
@Test
public void testVLongRandom() throws IOException {
{code}
Please add a line break between each test cases because of consistent coding
style.
{code:title=TestTFileSplit.java}
import org.junit.After;
import org.junit.Before;
{code}
{code:title=TestTFileSeqFileComparison.java}
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertFalse;
{code}
Please remove unused imports.
> Upgrade JUnit3 TestCase to JUnit 4 for tests of org.apache.hadoop.io package
> ----------------------------------------------------------------------------
>
> Key: HADOOP-12564
> URL: https://issues.apache.org/jira/browse/HADOOP-12564
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Reporter: Dustin Cote
> Assignee: Dustin Cote
> Priority: Trivial
> Attachments: MAPREDUCE-6505-1.patch, MAPREDUCE-6505-2.patch,
> MAPREDUCE-6505-3.patch, MAPREDUCE-6505-4.patch, MAPREDUCE-6505-5.patch
>
>
> Migrating just the io test cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
