> -----Original Message-----
> From: Michael A. Smith [mailto:mas@;apache.org]
> Sent: Wednesday, 23 October 2002 11:21 PM
> To: Jakarta Commons Developers List
> Subject: Re: cvs commit:
> jakarta-commons-sandbox/vfs/src/java/org/apache/commons/vfs/util
> Messages.java
> >
> > - public JarFileObject( FileName name,
> > - ZipEntry entry,
> > - ZipFile zipFile,
> > - JarFileSystem fs )
> > + public JarFileObject( final FileName name,
> > + final ZipEntry entry,
> > + final ZipFile zipFile,
> > + final JarFileSystem fs )
> > {
> > super( name, entry, zipFile, fs );
> > }
>
> checkstyle was complaining about that?
Uh, no. I added the finals out of habit.
>
> [snip]
>
> > Index: Messages.java
> > ===================================================================
> > RCS file:
> /home/cvs/jakarta-commons-sandbox/vfs/src/java/org/apache/commons/
vfs/util/Messages.java,v
> > retrieving revision 1.3
> > retrieving revision 1.4
> > diff -u -r1.3 -r1.4
> > --- Messages.java 23 Oct 2002 11:59:42 -0000 1.3
> > +++ Messages.java 23 Oct 2002 13:09:10 -0000 1.4
> > @@ -70,7 +70,7 @@
> > public class Messages
> > {
> > /** Map from message code to MessageFormat object for
> the message. */
> > - private static final Map messages = new HashMap();
> > + private static Map messages = new HashMap();
> > private static ResourceBundle resources;
> >
> > private Messages()
>
> checkstyle was complaining about that?
Yep. It wanted
private static final Map MESSAGES = new HashMap();
I prefered to get rid of the final.
Adam
--
To unsubscribe, e-mail: <mailto:commons-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@;jakarta.apache.org>
