On Wed, 23 Oct 2002, Adam Murdoch wrote:
> > > - public JarFileObject( FileName name,
> > > - ZipEntry entry,
> > > - ZipFile zipFile,
> > > - JarFileSystem fs )
> > > + public JarFileObject( final FileName name,
> > > + final ZipEntry entry,
> > > + final ZipFile zipFile,
> > > + final JarFileSystem fs )
> > > {
> > > super( name, entry, zipFile, fs );
> > > }
> >
> > checkstyle was complaining about that?
>
> Uh, no. I added the finals out of habit.
ok. just wondering. :)
> > > @@ -70,7 +70,7 @@
> > > public class Messages
> > > {
> > > /** Map from message code to MessageFormat object for
> > the message. */
> > > - private static final Map messages = new HashMap();
> > > + private static Map messages = new HashMap();
> > > private static ResourceBundle resources;
> > >
> > > private Messages()
> >
> > checkstyle was complaining about that?
>
> Yep. It wanted
>
> private static final Map MESSAGES = new HashMap();
>
> I prefered to get rid of the final.
ah... makes sense (even though you already had what you say it wanted
-- it probably wanted private final static or final private static or
something in a different order). :)
regards,
michael
--
Michael A. Smith
[EMAIL PROTECTED]
--
To unsubscribe, e-mail: <mailto:commons-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@;jakarta.apache.org>
