On Mon, 11 Aug 2003, __matthewHawthorne wrote:
> A few items: > > I submitted another patch today for [io], continuing the refactoring > process. Cool :) > Jeremias seems to be pretty busy, I would appreciate it if anyone else > who is > familiar with the codebase (or is just willing to help) would take a > look and > commit these for me. (Tim?) If I get a chance I will. IO is as ever, at the bottom of my list of todo's. > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22075 > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22332 > > It seems that [io], in some ways, is still in its initial phase, still > trying to > outgrow the multiple places that the code was contributed from. There > is a lot of code from Avalon, and perhaps they have different coding > standards > than commons (brace on newline, final method parameters, etc.) I would > assume > that it is ok to shift back towards the typical Sun guidelines. Any > objections? Usually I think it would be debatable, but as there is not an Avalon representative maintaining the code I think we're free to modify the style.B > Since this project mainly deals with file system io, there are a fair > amount of > test files that are read from and written to. At least one of the files is > located in the src/test tree. I created a data/test directory for this > file, and > if the need arises, may create a test file loader which can manage > details such > as test directories and files, instead of having each test case contain > hardcoded file names (and sometimes directories.) Although the > directories are > relative, I usually prefer to load the resources from the classpath. > This makes > it easier to run tests from multiple environments, so that the tests can > run and > pass from the command line with Ant or in an IDE like Eclipse. Any thoughts? I like it. I'm not an old-hand at unit testing, so figuring out a nice way to handle testing the IO kept beating me. I felt that using a system resource in a test, but I realise now there just isn't another way [except occasionally when a StringReader or ByteArrayInputStream may be used]. I think using the in-memory streams is a good practice that we should use at all times, but File itself is tied to the system. Hen --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
