Re: [Validator] Url Validation Patch - [Bug 28190]

[Robert Leland]

Robert Leland wrote:

Niall Pemberton wrote:

Any feedback on the patch I submitted adding the ability to return an 
error code from when validating Url's?

 http://issues.apache.org/bugzilla/show_bug.cgi?id=28190

Niall

 

I have a deadline this Friday that will probably stretch over the 
weekend.
After that I'll have a chance to review it. Looking at it briefly, the 
patch itself looks ok.
The main items I would look at is how it fits in with the other 
validations and if there was
any mechanism that might be generalized to keep the validations 
consistent.

-Rob 
I am inclined to simplify the code and always return the expandedCode, 
that would make the control flow simpler.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]