Robert Leland wrote > Niall Pemberton wrote: > > >Any feedback on the patch I submitted adding the ability to return an error code from when validating Url's? > > > > http://issues.apache.org/bugzilla/show_bug.cgi?id=28190 > > > > > >Niall > > > > > I have a deadline this Friday that will probably stretch over the weekend. > After that I'll have a chance to review it. Looking at it briefly, the > patch itself looks ok.
OK Thanks. > The main items I would look at is how it fits in with the other > validations and if there was > any mechanism that might be generalized to keep the validations consistent. I think all validators should return a "ResultStatus" (currently a protected inner class in ValidatorResult) which could be made a public class and expanded to include an error code like this one. That would then provide a mechanism for this type of scenario and make it easier to add other features if other scenarios (not that I can think of any) arose in the future. Niall > -Rob > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
